Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix options handling #85

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kumavis
Copy link

@kumavis kumavis commented Apr 27, 2018

Fix uglifyify's handling of options, removing side effects

  • create a new options object then mutate before passing into uglify
  • change handling of error from ujs.minify to take advantage of capture's error handling

This PR is from #72, with merge conflicts resolved. Also redundant with some other PRs attempting to solve the same problem.

relevant PRs:
Fixes #72
Fixes #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants