Update unsloth_integration.md #2742
Open
+194
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qgallouedec
reviewed
Feb 2, 2025
docs/source/unsloth_integration.md
Outdated
|
|
||
| Section under construction. Feel free to contribute! | ||
| ## Table of Contents | ||
| - [Installation](#installation) |
There was a problem hiding this comment.
No need for a toc, you will have one automatically on the right with the doc builder
docs/source/unsloth_integration.md
Outdated
| 3. **Install Optional Dependencies**: | ||
| ```bash | ||
| pip install flash-attn==2.5.8 trl==0.8.6 accelerate==0.27.2 |
There was a problem hiding this comment.
Why do you need this very old version of trl?
| from transformers import TrainingArguments | ||
|
|
||
| trainer = TrainingArguments( |
There was a problem hiding this comment.
Trainer and training args are different things. There's probably an issue here
winglian
reviewed
Feb 3, 2025
docs/source/unsloth_integration.md
Outdated
| - Python 3.8+ | ||
| - PyTorch 2.0+ | ||
| - NVIDIA GPU with FP16 support (recommended) |
There was a problem hiding this comment.
Should probably also specify it is limited to single GPU
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.