[Liger] liger DPO support #2568
Open
+316
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Jan 17, 2025
tests/test_dpo_trainer.py
Outdated
| 3. Loss values are reasonable and finite | ||
| 4. Training works with both default and custom beta values | ||
| """ | ||
| beta_values = [0.1, 0.5] # Test multiple beta values |
There was a problem hiding this comment.
Can you use @parameterized.expand instead?
qgallouedec
reviewed
Jan 17, 2025
|
liger loss isn't compatible with ref precomputing right? If so we could add a warning or an error. |
qgallouedec
reviewed
Jan 17, 2025
docs/source/reducing_memory_usage.md
Outdated
Comment on lines
87
to
105
|
|
||
| ## Liger for reducing peak memory usage | ||
|
|
||
| [To complete] | ||
|
|
||
| <hfoptions id="liger"> | ||
| <hfoption id="DPO"> | ||
|
|
||
| To use Liger for reducing peak memory usage, use the following code snippet: | ||
|
|
||
| ```python | ||
| from trl import DPOConfig | ||
|
|
||
| training_args = DPOConfig(..., use_liger_loss=True) | ||
| ``` | ||
|
|
||
| </hfoption> | ||
| </hfoptions> |
There was a problem hiding this comment.
@kashif I've added this section in the new guide for reducing memory usage, if you've words to fill it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for Liger-kernel losses for the DPO Kernel
Needs: linkedin/Liger-Kernel#521