Display warning for unknown quants config instead of an error #35963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks for the fix ! Looks good ! |
MekkCyber
approved these changes
Jan 29, 2025
| @staticmethod | ||
| def supports_quant_method(quantization_config_dict): | ||
| quant_method = quantization_config_dict.get("quant_method", None) | ||
| # We need a special care for bnb models to make sure everything is BC .. |
There was a problem hiding this comment.
Can you please rewrite or remove the comment? What are bnb models? what is BC? BC = backwards compatible? If so please write it.
Comment on lines
+3637
to
+3640
| pre_quantized = getattr( | ||
| config, "quantization_config", None | ||
| ) is not None and AutoHfQuantizer.supports_quant_method(config.quantization_config) | ||
|
|
There was a problem hiding this comment.
Suggested change
| pre_quantized = getattr( | |
| config, "quantization_config", None | |
| ) is not None and AutoHfQuantizer.supports_quant_method(config.quantization_config) | |
| pre_quantized = getattr(config, "quantization_config", None) | |
| if pre_quantized is not None and AutoHfQuantizer.supports_quant_method(config.quantization_config): | |
| pre_quantized = None # Unsupported methods are just skipped | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes how we deal with unknown quantization config. Instead of raising an error, we just skip the quantization logic and display a warning. Partially fixes #35471