Fix RMSNormGated in Zamba2 #35943
Open
Fix RMSNormGated in Zamba2 #35943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rebase zamba2
rebase on upstream
Co-authored-by: Arthur <[email protected]>
This reverts commit 9007a52.
Co-authored-by: Arthur <[email protected]>
vasqu
reviewed
Jan 29, 2025
| class Zamba2RMSNormGated(MambaRMSNormGated): | ||
| pass | ||
| class Zamba2RMSNormGated(torch.nn.Module): |
There was a problem hiding this comment.
I think this will also affect the mamba2 code then (as codestral mamba also uses ngroups > 1) - so I'd be for implementing this in the mamba2 code and use modular then.
cc @molbap
There was a problem hiding this comment.
I think so, but as I'm no maintainer I leave the decision to the others 👀
5 tasks
|
cc @molbap I think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends
Zamba2RMSNormGatedto allowconfig.mamba_ngroups>1. The Zamba2 7B checkpoints haveconfig.mamba_ngroups=2so this change is necessary to have the correct forward pass.I defined
Zamba2RMSNormGatedinside modular_zamba2.py instead of importing it, as this differs from the definition in modeling_mamba2.py. The implementation in this PR is the torch version of the mamba-ssm implementation of the original mamba2 (used here and torch implementation given here).Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @Cyrilvallez