-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModernBERT FlexAttention #35423
Open
staghado
wants to merge
12
commits into
huggingface:main
Choose a base branch
from
staghado:flexattn-modernbert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ModernBERT FlexAttention #35423
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cd78f8d
FlexAttention support 1/n
staghado 88cd884
FlexAttention with unpadded RoPE using GemmaRotaryEmbeddings
staghado 56c3846
Merge branch 'huggingface:main' into flexattn-modernbert
staghado d8d468e
fix check
staghado 47758db
fix: simplify condition
staghado 2c8a5b0
Merge branch 'main' into flexattn-modernbert
staghado 43dd738
separate FlexAttn from modeling & compile attention methods
staghado 1ebcaa1
run make fixup
staghado b3daa28
update position_ids for flex_attention to use cu_seqlens
staghado 101113f
Merge remote-tracking branch 'upstream/main' into flexattn-modernbert
staghado 2fe0efa
Merge branch 'main' into flexattn-modernbert
staghado a5d8574
Merge branch 'main' into flexattn-modernbert
staghado File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are needed to actually use the flexattention kernels but the
utils/modular_model_converter.py
does not allow it in the converted file.let me know if there is a better way to do this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @ArthurZucker @tomaarsen (sorry for the ping)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any ideas on how to support compiling the flex_attention function in transformers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The failing CI is related to these two lines, there is no clear way how to support compile in a clean way