Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pytorch memory stats along with PyNVML #81

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Add Pytorch memory stats along with PyNVML #81

merged 7 commits into from
Oct 31, 2023

Conversation

IlyasMoutawwakil
Copy link
Member

This PR adds two memory stats to the inference_results.csv file: max_memory_allocated and max_memory_reserved for both forward passand generate pass.

@IlyasMoutawwakil
Copy link
Member Author

IlyasMoutawwakil commented Oct 31, 2023 •
edited
Loading

this PR introduces the deprecation without breaking of forward.peak_memory(MB) and generate.peak_memory(MB) in favor of forward.max_memory_used(MB) and generate.max_memory_used(MB)

@IlyasMoutawwakil IlyasMoutawwakil merged commit 9a0db86 into main Oct 31, 2023
10 checks passed
@IlyasMoutawwakil IlyasMoutawwakil deleted the add-pytorch-mem-stats branch November 2, 2023 20:13
@IlyasMoutawwakil IlyasMoutawwakil mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyasMoutawwakil @actions-user