Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass backend name to EnergyTracker in Training scenario #279

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Pass backend name to EnergyTracker in Training scenario #279

merged 2 commits into from
Sep 25, 2024

Conversation

asesorov
Copy link
Contributor

Seems there is a missing required backend parameter in EnergyTracker initialization in training scenario, which causes a value error.

@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Sep 25, 2024 •
edited
Loading

Thanks! can you add energy=not rocm_system() here https://github.com/huggingface/optimum-benchmark/blob/main/tests/test_api.py#L67 so that it can be tested

@IlyasMoutawwakil IlyasMoutawwakil added the api [CI] Requires and enables running all API tests label Sep 25, 2024
@IlyasMoutawwakil IlyasMoutawwakil merged commit 306b62b into huggingface:main Sep 25, 2024
45 of 55 checks passed
vicoooo26 pushed a commit to vicoooo26/optimum-benchmark that referenced this pull request Oct 23, 2024
@asesorov @vicoooo26
Pass backend name to EnergyTracker in Training scenario (huggingface#279
c3908cb 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api [CI] Requires and enables running all API tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asesorov @IlyasMoutawwakil