Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

works for fp8 with deepspeed #3361

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

XiaobingSuper
Copy link

What does this PR do?

For fp8 training with deepspeed, it can't work for accelerate>0.34.2, the root cause is that we use the AcceleratorState.mixed_precision to check whether fp8 is enabled or not, but for deepspeed, the AcceleratorState.mixed_precision is always bf16 even the given mixed_precision of accelerate is fp8.

Fixes #3360

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@XiaobingSuper XiaobingSuper force-pushed the xiaobing/fp8_deepspeed branch from 5d214b9 to a2ded14 Compare January 23, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP8 training can't works with deepspeed
1 participant