Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 승부차기 타임라인 등록 기능 구현 #240

Merged
merged 9 commits into from
Sep 25, 2024
Merged

[FEAT] 승부차기 타임라인 등록 기능 구현 #240

merged 9 commits into from
Sep 25, 2024

Conversation

Jin409
Copy link
Contributor

@Jin409 Jin409 commented Sep 23, 2024

🌍 이슈 번호

📝 구현 내용

  • 승부차기 타임라인 기능 구현

@Jin409 Jin409 marked this pull request as ready for review September 23, 2024 08:14
@Jin409 Jin409 self-assigned this Sep 23, 2024
hodadako
hodadako reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많았어~ 코멘트 남긴것만 확인해줘 👍🏻

src/test/java/com/sports/server/command/game/domain/GameTest.java Show resolved Hide resolved
@Jin409 Jin409 merged commit 9f12ecf into main Sep 25, 2024
1 check passed
@Jin409 Jin409 deleted the feat/#236-pk-timeline branch September 25, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodadako hodadako hodadako left review comments

Assignees

@Jin409 Jin409

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 승부차기 타임라인 등록 기능 구현
2 participants
@Jin409 @hodadako