-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] 리그 생성 시 자동으로 Organization 등록되도록 수정 #223
Closed
Closed
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a7ae04d
[FEAT] 경기 수정 기능 구현 #208
Zena0128 3ee97b1
[TEST] 경기 수정 기능 서비스 테스트 추가 #208
Zena0128 888f13a
[TEST] 경기 수정 기능 인수 테스트 추가 #208
Zena0128 4bb4552
[DOCS] 경기 수정 기능 문서화 추가
Zena0128 6c51383
[DOCS] 누락된 파라미터 추가
Zena0128 1bb6e9a
[MERGE] 메인과 병합
Zena0128 0b6fe12
[TEST] 서비스 테스트에서 LocalDateTime.now()를 사용해 테스트하지 않도록 수정
Zena0128 f4551e3
[TEST] 게임 수정 서비스 테스트 피드백 반영 #208
Zena0128 c37a689
[FEAT] security config에 게임 수정 Url 추가 #208
Zena0128 86617cf
[TEST] 게임 수정 인수 테스트 피드백 반영 #208
Zena0128 d50a18c
[MERGE] 메인 브랜치 변경 사항 반영 #208
Zena0128 09b53ba
[REFACTOR] 캡슐화를 위해 서비스단에서 사용되는 게임 수정 메소드 변경 #208
Zena0128 846e324
[REFACTOR] 유지보수성 향상을 위해 update 메소드들 분리 #208
Zena0128 82ae0a8
[TEST] 인수 테스트에서 게임 수정 테스트 시 수정 후 다시 가져와 정보 확인하도록 추가 #208
Zena0128 2db3e1b
[FEAT] 게임 정보 상세조회 시 누락된 round 추가 #208
Zena0128 1c69fc7
[DOCS] 게임 상세조회 수정한 부분 문서화 추가
Zena0128 73329f1
Merge branch 'main' into feat/#208-game
Zena0128 725ac4f
[REFACTOR] 게임 수정 시 엔티티가 DTO에 의존하거나 불필요한 엔티티 생성하지 않도록 수정 #208
Zena0128 afdb5e7
[MERGE] 메인 브랜치 변경 사항 반영 #215
Jin409 d155abc
[FEAT] 출전 선수 조회 기능 구현 #215
Jin409 e943348
[MERGE] 메인 브랜치 병합
Zena0128 9e80f35
[MERGE] 메인 브랜치 병합
Zena0128 f362032
[MERGE] 메인 브랜치 병합
Zena0128 002ad86
[TEST] 라인업 선수가 출전 중인지 확인하도록 테스트 수정 #215
Jin409 f699b62
[TEST] 사용되지 않는 fixture 용 repository 삭제 #215
Jin409 2498d4d
[MERGE] 메인 브랜치 병합
Zena0128 488c898
Merge branch 'main' of https://github.com/hufscheer/spectator-server …
Zena0128 f193d7f
[REFACTOR] 리그 생성 시 organization을 요청파라미터로 받지 않아도 자동으로 채워지도록 수정 #222
Zena0128 a503b2f
[TEST] 리그 생성 인수 테스트 수정 #222
Zena0128 8883196
[DOCS] 리그 생성 문서화 수정 #222
Zena0128 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠.. 이렇게 하면 쿼리가 한번 더 나가게 되지 않을까요?
AuthMemberResolver 에서 Member 를 자동으로 주입하고 있기 때문에 어쩔 수 없으려나요? 어떻게 생각하시나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jin409 join쿼리로 member의 organization까지 한 번에 가져오는 방법도 생각해보긴 했는데..
어차피 멤버는 한 개만 들어와서 join쿼리의 효율성이 높지 않기도 하고,
join쿼리로 organization을 가져오든, get으로 organization을 가져오든 상관 없이
인증 과정에서 파라미터로 받는 멤버를 조회하는 쿼리 한 번 + organization 가져오는 쿼리 한 번 총 두 번 실행되어 유의미한 차이가 없을 것으로 생각해서 요렇게 짜긴 했어요!
더 효율적인 방법이 있으려나요?? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
흠 그쵸 그쵸 어차피 한개니까 괜찮을 것 같아요!
그리고 organization 이 이제 의미가 없어서 데이터베이스 상에 데이터도 얼마 없을 것 같아서 괜찮을 것 같네요! 굳굳