Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foe traffic signals to observation signals. #1714

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Nov 16, 2022

This change is intended to expose foe traffic signals through AgentInterface configuration.

@Gamenot Gamenot requested review from saulfield, Adaickalavan and qianyi-sun and removed request for saulfield November 26, 2022 04:46
@Gamenot Gamenot requested review from saulfield, Adaickalavan and qianyi-sun and removed request for Adaickalavan, saulfield and qianyi-sun January 4, 2023 20:48
@Gamenot Gamenot force-pushed the tucker/add-intersection_signals branch from 710152a to c225cae Compare January 4, 2023 20:51
Comment on lines 1307 to 1318
if self._include_foes:
self._find_foe_signals(lane, used_features, upcoming_signals)

lookahead = self._lookahead - lane.length + lane_pos.s
self._find_signals_ahead(lane, lookahead, plan.route, upcoming_signals)
self._find_signals_ahead(
lane,
lookahead,
plan.route,
self._include_foes,
used_features,
upcoming_signals,
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have functions with return values, compared to relying on functions with side effects.

@Gamenot Gamenot added this to the `develop` branch close-down milestone Feb 14, 2023
@Gamenot Gamenot force-pushed the tucker/add-intersection_signals branch 2 times, most recently from 7e5c491 to a5d0ff9 Compare April 27, 2023 21:24
@Gamenot Gamenot force-pushed the tucker/add-intersection_signals branch from a5d0ff9 to ef8ef50 Compare April 28, 2023 18:57
@Gamenot Gamenot changed the base branch from develop to master April 28, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants