Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idempotency key draft #70

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Nov 23, 2023

Here's a very basic first draft.

I could expand on some of more advanced topics, like what happens if there are multiple steps and some of them succeed but another craps out and the client retries?

https://medusajs.com/blog/idempotency-nodejs-express-open-source/

image

Is that getting too in the weeds? Could we put a "Further reading" section in?

Also, should I get stuck into when and why a PATCH might want to do this with examples like incrementBy or shall we leave that to the imagination of the reader?

Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philsturgeon! Smattering of comments added inline. On your questions:

  • I think adding some 'Further reading' or similar might be interesting, but beyond that no need to fully explain how to unwind complicated multi-step cases.
  • I think a short section on PATCH as an aside towards the end would be interesting, yes.

src/posts/idempotency-keys.md Outdated Show resolved Hide resolved
src/posts/idempotency-keys.md Outdated Show resolved Hide resolved
src/posts/idempotency-keys.md Show resolved Hide resolved
src/posts/idempotency-keys.md Outdated Show resolved Hide resolved
src/posts/idempotency-keys.md Outdated Show resolved Hide resolved
src/posts/idempotency-keys.md Outdated Show resolved Hide resolved
@philsturgeon
Copy link
Contributor Author

Brilliant, it's good to know the sort of things you're interested in, so this has heped tailor the article for your audience. Check it out now.

Copy link
Member

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the edits @philsturgeon! I'll do last tweaks and publish in the next week or two 👍

@pimterry pimterry merged commit 2c638bb into httptoolkit:main Dec 12, 2023
7 checks passed
pimterry pushed a commit that referenced this pull request Apr 23, 2024
* feat(HTD-47): add terms privacy hero

* fix(HTD-47): remove unused title
pimterry pushed a commit that referenced this pull request Apr 23, 2024
* feat(HTD-47): add terms privacy hero

* fix(HTD-47): remove unused title
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants