-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
idempotency key draft #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @philsturgeon! Smattering of comments added inline. On your questions:
- I think adding some 'Further reading' or similar might be interesting, but beyond that no need to fully explain how to unwind complicated multi-step cases.
- I think a short section on PATCH as an aside towards the end would be interesting, yes.
Brilliant, it's good to know the sort of things you're interested in, so this has heped tailor the article for your audience. Check it out now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the edits @philsturgeon! I'll do last tweaks and publish in the next week or two 👍
* feat(HTD-47): add terms privacy hero * fix(HTD-47): remove unused title
* feat(HTD-47): add terms privacy hero * fix(HTD-47): remove unused title
Here's a very basic first draft.
I could expand on some of more advanced topics, like what happens if there are multiple steps and some of them succeed but another craps out and the client retries?
https://medusajs.com/blog/idempotency-nodejs-express-open-source/
Is that getting too in the weeds? Could we put a "Further reading" section in?
Also, should I get stuck into when and why a PATCH might want to do this with examples like incrementBy or shall we leave that to the imagination of the reader?