Add support for custom tor configuration file entered by the user #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new feature allows the user to specify custom tor configurations that he may have created manually or from Nipe itself (through "install" command) using the '-c' flag with "start" command. $ ./nipe.pl start -c $HOME/.nipe_torrc In case the user's config doesn't contain some of the values required by Nipe, it will use its defined default value. For now the default values are hardcoded within Nipe's source code, but may change in the future for a more flexible approach.
|
I'm going to recheck this PR's code. I may have forgotten to check some cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #36 is solved by this PR by allowing the user to pass a custom config file (from a different tor instance or something like that) using the '-c' flag with the 'start' command.
At the same time, issue #79 should also be solved through the default values added to the code in case the ID_LIKE key is not present in /etc/os-release file. However, in case we identify that issue #79 is more deeper we're going to need new patches to solve that.