Update Addon to use @ember/test-waiters #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
approved these changes
May 11, 2024
|
Would love to see this over the line. Eager to embroiderify |
|
This is our last blocker, anybody able to get this out? |
|
@runspired @mixonic if there anything i need to do to get this released? |
|
Anything we can do to get this released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've experienced some issues with the old test waiter system when using this addon with embroider builds #15 , this updates the addon to use the "new" test waiter system. This appears to fix my issue.
Note: I added a deprecation message for
registerWaiterto give time but open to just removing it in this PR.Bumped
@embroider/test-setupthis should fix the embroider failures.