Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logging to ddp messages #5

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

added logging to ddp messages #5

wants to merge 10 commits into from

Conversation

hmn
Copy link
Contributor

@hmn hmn commented Mar 8, 2018

No description provided.

@coveralls
Copy link

coveralls commented Mar 8, 2018

Coverage Status

Coverage decreased (-3.2%) to 52.613% when pulling d808778 on hmn:master into 6f7d1ec on hthiery:master.

pyps4/ddp.py Outdated
return

try:
if broadcast:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be removed form the try, except block ... maybe in another

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what part are you referring to here?

pyps4/ddp.py Outdated
sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
except OSError as error:
_LOGGER.error('failed to create socket, %s', error)
return
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is a good idea to return siliently. The errors would not be catched anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continuing just seems to break more, and the error is already reported, so I don't know what a better alternative would be.

basicly what you are trying is not working and you are informed why, in my opinion that seems better than breaking with an unhandled exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants