-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added logging to ddp messages #5
base: master
Are you sure you want to change the base?
Conversation
pyps4/ddp.py
Outdated
return | ||
|
||
try: | ||
if broadcast: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed form the try, except block ... maybe in another
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what part are you referring to here?
pyps4/ddp.py
Outdated
sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM) | ||
except OSError as error: | ||
_LOGGER.error('failed to create socket, %s', error) | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it is a good idea to return siliently. The errors would not be catched anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuing just seems to break more, and the error is already reported, so I don't know what a better alternative would be.
basicly what you are trying is not working and you are informed why, in my opinion that seems better than breaking with an unhandled exception
* 'master' of https://github.com/hthiery/python-ps4: readme: fix readme: update Add remote key feature add python 3.6 to travis build
…https://github.com/hthiery/python-ps4 * 'master' of github.com:hmn/python-ps4: * 'master' of https://github.com/hthiery/python-ps4: added docker testing/dev env fixed install dependency as pycryptodomex is only needed
No description provided.