-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hstream-sql: code clean up #1488
Conversation
I had already detected some bugs and some point to fix or inspect, let me push them further... |
left a undefined here cc @Commelina 690e594 |
hstream-sql/hstream-sql.cabal
Outdated
@@ -37,8 +37,9 @@ flag hstream_use_v2_engine | |||
|
|||
common shared-properties | |||
ghc-options: | |||
-Wall -Wcompat -Widentities -Wincomplete-record-updates | |||
-Wincomplete-uni-patterns -Wpartial-fields -Wredundant-constraints | |||
-Wall -Wextra -Werror -Wno-name-shadowing -Wno-orphans -Wcompat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why turn off these warnings(e.g., name-shadowing) at the package level? Prefer to turn it off at the module level if you really want.
Yes, it is acceptable. BTW, this type (window in |
Would you like to merge it now, or do you have more code to commit...? @alissa-tung |
i think there will not be more commits
|
OK. It can be merged after passing checks. |
PR Description
Type of change
Summary of the change and which issue is fixed
Main changes: TODO
Checklist
format.sh
underscript