Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error taking screenshots in Vulkan on many devices #19608

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

hrydgard
Copy link
Owner

@hrydgard hrydgard commented Nov 7, 2024

Was trying to rotate an empty buffer instead of the screenshot, oops.

Only affects Android since it's the only platform that uses rotated framebuffers.

Additionally, fix a validation error. (not actually checking the flag when taking a screenshot, because support for TRANSFER_SRC on swapchain images seems universal).

Fixes #19585

@hrydgard hrydgard added the User Interface PPSSPP's own user interface / UX label Nov 7, 2024
@hrydgard hrydgard added this to the v1.19.0 milestone Nov 7, 2024
@hrydgard hrydgard merged commit ff6a10a into master Nov 7, 2024
19 checks passed
@hrydgard hrydgard deleted the screenshot-fix branch November 7, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface PPSSPP's own user interface / UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vulkan , TakeGameScreenshot is not working
1 participant