-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: always update development images #621
Merged
fniephaus
merged 3 commits into
hpi-swa:master
from
theseion:force-update-development-images
Feb 12, 2024
Merged
feat: always update development images #621
fniephaus
merged 3 commits into
hpi-swa:master
from
theseion:force-update-development-images
Feb 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
theseion
commented
Dec 23, 2023
- new option to force download of an image and override the cache
- never use the cached image for in-development versions (*-trunk | *-alpha)
Note: this change is necessary due to a fix a couple of months back that fixed the caching behaviour (#604). |
theseion
force-pushed
the
force-update-development-images
branch
4 times, most recently
from
December 23, 2023 10:53
3f916b9
to
e9b2469
Compare
fniephaus
reviewed
Dec 27, 2023
fniephaus
requested changes
Feb 12, 2024
- new option to force download of an image and override the cache - never use the cached image for in-development versions (*-trunk | *-alpha)
- the new command is now called `--overwrite-cache` - a new debug flag `--force-cache` overrides `--overwrite-cache` and can be used to force alpha / trunk builds to be reused.
theseion
force-pushed
the
force-update-development-images
branch
from
February 12, 2024 12:09
7a4e978
to
9fe50df
Compare
fniephaus
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.