Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer load STON for Squeak >= 5.4 #528

Conversation

theseion
Copy link
Collaborator

Split package and group methods for Squeak in two (similar to Pharo).

Fixes #527.

Split package and group methods for Squeak in two (similar to Pharo)
@fniephaus fniephaus requested a review from tom95 May 25, 2021 08:14
@tom95
Copy link
Contributor

tom95 commented May 25, 2021

Thank you for the PR @theseion! Two things to note still:

  • there will most likely not be a squeak5.4, only squeak6
  • I have a hunch that squeak<=5.3 builds would also break if their cached images were ever updated to include the newer Metacello. A more longterm fix for this odd dependency incompatibility issue might thus be actually a check whether STON is already in the image instead of dispatching based on version.

But I'm not a 100% sure on the second point just yet. Is this issue in any way time-critical for you? Otherwise I would check laeter today or tomorrow (unless you beat me to it of course :)) and report back, if successful maybe with a new PR based on yours.

@theseion
Copy link
Collaborator Author

theseion commented May 25, 2021

SmalltalkCI overrides STON-Core in Squeak trunk

True. But 6 has been coming for about 2 years now? And 5.4 matches the Metacello attribute if I'm not mistaken. For safety, we could add #squeak6.x to the spec for 5.4.

I have a hunch that squeak<=5.3 builds would also break

Right. I wasn't aware that's an option.
We could just put that check into the baseline, like you suggested. I think that would be fine. There is one alternative though and that is to depend on a specific Metacello version in the SmalltalkCI baseline. I don't think we should do that but I'm pointing it out for completeness.

This isn't time critical but would be nice to get fixed in the next couple of days (or weeks). Feel free to adapt the PR.

@theseion
Copy link
Collaborator Author

Superseded by #530.

@theseion theseion closed this May 25, 2021
@theseion theseion deleted the 527-smalltalkci-overrides-ston-core-in-squeak-trunk branch May 25, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SmalltalkCI overrides STON-Core in Squeak trunk
2 participants