Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency on SWALint Outside of Testing #145

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Conversation

BenBals
Copy link
Contributor

@BenBals BenBals commented Aug 2, 2020

Fixes #143

Please try again with this version, @sinnaj-r.

@BenBals BenBals requested a review from sinnaj-r August 2, 2020 14:35
@sinnaj-r
Copy link
Contributor

sinnaj-r commented Aug 2, 2020

Fixes #143

Please try again with this version, @sinnaj-r.

Thank you, I will try once the smalltalkhub.com Servers are online again.
(And allow me to install Metacello on my fresh image) ...

@BenBals BenBals self-assigned this Aug 2, 2020
@BenBals BenBals added this to the Submission milestone Aug 2, 2020
@BenBals
Copy link
Contributor Author

BenBals commented Aug 3, 2020

Is smalltalkhub back up again? I can ping it, but the website does not load. The missing web ui seems to be on purpose according to some mailing list entries.

@sinnaj-r
Copy link
Contributor

sinnaj-r commented Aug 4, 2020

Is smalltalkhub back up again? I can ping it, but the website does not load. The missing web ui seems to be on purpose according to some mailing list entries.

At least on my machines I can't install Metacello on an fresh Squeak Image.

I get stuck here:

Screen Shot 2020-08-04 at 3 22 09 PM

Maybe @phlprcks, @kej-jay or @robertkirsten can confirm ?
(Steps: Download Squeak from Website for your platform; In the Setup-"Popup" tick the Git Support-Checkbox, run the Installation)

@phlprcks
Copy link
Contributor

phlprcks commented Aug 5, 2020

Is smalltalkhub back up again? I can ping it, but the website does not load. The missing web ui seems to be on purpose according to some mailing list entries.

At least on my machines I can't install Metacello on an fresh Squeak Image.

I get stuck here:

Screen Shot 2020-08-04 at 3 22 09 PM

Maybe @phlprcks, @kej-jay or @robertkirsten can confirm ?
(Steps: Download Squeak from Website for your platform; In the Setup-"Popup" tick the Git Support-Checkbox, run the Installation)

I am stuck (probably) at the same point, however the error message suggests that there is a load conflict with the existing BaselineOfSton

Is that the same error you were receiving, @sinnaj-r ?
image

@robertkirsten
Copy link
Contributor

robertkirsten commented Aug 5, 2020

Is smalltalkhub back up again? I can ping it, but the website does not load. The missing web ui seems to be on purpose according to some mailing list entries.
...
Is that the same error you were receiving, @sinnaj-r ?
image

I have the same problem as @phlprcks.

@sinnaj-r
Copy link
Contributor

sinnaj-r commented Aug 5, 2020

Please install the SWALint only when it's needed in Postload:

(Or if the #SwaLint Global exists)

@sinnaj-r
Copy link
Contributor

sinnaj-r commented Aug 5, 2020

Please install the SWALint only when it's needed in Postload:

Apart from that when I e.g. comment out that line it's working and I get no deprecation warning 👍

@BenBals BenBals merged commit 777823e into development Aug 6, 2020
@BenBals BenBals deleted the fix-#143 branch August 6, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation in Squeak 5.3 emits deprecation warning
4 participants