Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation in Squeak 5.3 emits deprecation warning #143

Closed
sinnaj-r opened this issue Aug 1, 2020 · 4 comments · Fixed by #145
Closed

Installation in Squeak 5.3 emits deprecation warning #143

sinnaj-r opened this issue Aug 1, 2020 · 4 comments · Fixed by #145
Assignees
Milestone

Comments

@sinnaj-r
Copy link
Contributor

sinnaj-r commented Aug 1, 2020

When Upgrading to a new Algernon Version in Squeak with the provided Snippet (as created in #125 ), you have to dismiss ~20 Deprecation Warnings.

@BenBals
Copy link
Contributor

BenBals commented Aug 1, 2020

We should definitely never use deprecated code.

Can you post the warnings as I cannot reproduce that? Then I can take a look.

@BenBals BenBals added this to the Submission milestone Aug 1, 2020
@sinnaj-r
Copy link
Contributor Author

sinnaj-r commented Aug 1, 2020

A quick debug shows, that we install SWALint as a dependency and that this module has the deprecations (or triggers them in Squot). You can see the same Warnings in the CI-Logs.
I'm not sure why we install SWALint, but if we can't remove it, we will have to wait for them to fix the issue. (Might be this one hpi-swa-teaching/SwaLint#43 or this one at Squot: hpi-swa/Squot#266)

Steps to reproduce:
Download a fresh Squeak 5.3 Version. Run the Install Snippet for the development branch.

I get the following warnings:

Screen Shot 2020-08-01 at 1 18 15 PM

@BenBals
Copy link
Contributor

BenBals commented Aug 1, 2020

Thank you.

The thing is that we need SWA Lint as a dependency to run the lints in CI. I don't know if there is a way to not install that for a normal installation.

Consider contacting @MrModder via email about this. I feel like he will be able to offer advice.

@LeonMatthes
Copy link

The culprit is this code in the baseline:

 spec
        group: 'default' with: #('Algernon');
        group: 'Tests' with: #('AlgernonTests');
	group: 'default' with: #('PlugIns');
	group: 'portability' with: #('PlugIns');
	group: 'Core' with: #('SwaLint-Core');
	group: 'PlugIns' with: #('SwaLint-PlugIns').

Specifically, group: 'default' with: #('PlugIns'); requires the SwaLint-Plugins for the default installation of Algernon.
If you were to remove this line and change the 'Tests' package to require the Plugins, SwaLint would only be loaded whenever the tests are loaded.

i.e.:

 spec
        group: 'default' with: #('Algernon');
        group: 'Tests' with: #('AlgernonTests' 'PlugIns');
	group: 'portability' with: #('PlugIns');
	group: 'Core' with: #('SwaLint-Core');
	group: 'PlugIns' with: #('SwaLint-PlugIns').

Before taking such a step you should be very confident that the default installation of Algernon does not require them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants