make inbox browser more robust against network errors

Catch errors before they bubble up to the rendering engine. Thanks to @roberthirschfeld for the bug report!
hpi-swa-lab · Feb 1, 2024 · 108a59b · 108a59b
1 parent 358c6bd
commit 108a59b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/...queakInboxTalk.package/TalkInboxBrowser.class/instance/conversationHelpAtRow.atColumn..st b/...queakInboxTalk.package/TalkInboxBrowser.class/instance/conversationHelpAtRow.atColumn..st
@@ -5,4 +5,8 @@ conversationHelpAtRow: rowIndex atColumn: columnIndex
 	conversation := self conversations at: rowIndex ifAbsent: [^ nil].
 	conversation = #searching ifTrue: [^ nil].
 
-	^ self conversationHelpFor: conversation atColumnNamed: (self columnNameAt: columnIndex)
+	^ [self conversationHelpFor: conversation atColumnNamed: (self columnNameAt: columnIndex)]
+		on: Error , Warning , Halt do: [:ex |
+			'{1} {2}' asText format:
+				{(ToolIcons iconNamed: #exception) talkAsText.
+				ex description}]
diff --git a/...queakInboxTalk.package/TalkInboxBrowser.class/instance/conversationIconAtRow.atColumn..st b/...queakInboxTalk.package/TalkInboxBrowser.class/instance/conversationIconAtRow.atColumn..st
@@ -10,4 +10,5 @@ conversationIconAtRow: rowIndex atColumn: columnIndex
 	conversation := self conversations at: rowIndex ifAbsent: [^ nil].
 	conversation = #searching ifTrue: [^ nil].
 
-	^ self conversationIconFor: conversation atColumnNamed: (self columnNameAt: columnIndex)
+	^ [self conversationIconFor: conversation atColumnNamed: (self columnNameAt: columnIndex)]
+		on: Error , Warning , Halt do: [:ex | ToolIcons iconNamed: #exception]
diff --git a/packages/SqueakInboxTalk.package/TalkInboxBrowser.class/methodProperties.json b/packages/SqueakInboxTalk.package/TalkInboxBrowser.class/methodProperties.json
@@ -87,9 +87,9 @@
 		"contents" : "ct 7/3/2021 02:00",
 		"contributeMenu:" : "ct 7/8/2021 13:32",
 		"conversationColumns" : "ct 5/15/2023 19:37",
-		"conversationHelpAtRow:atColumn:" : "ct 7/20/2021 20:25",
+		"conversationHelpAtRow:atColumn:" : "ct 2/1/2024 20:11",
 		"conversationHelpFor:atColumnNamed:" : "ct 7/20/2021 20:24",
-		"conversationIconAtRow:atColumn:" : "ct 7/20/2021 20:25",
+		"conversationIconAtRow:atColumn:" : "ct 2/1/2024 20:06",
 		"conversationIconFor:atColumnNamed:" : "ct 7/20/2021 23:13",
 		"conversationMenu:" : "ct 6/2/2023 19:44",
 		"conversations" : "ct 7/2/2021 16:57",