-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Instance Probes #162
base: develop
Are you sure you want to change the base?
Add Instance Probes #162
Conversation
This reverts commit 0938dfa "Enter commit log message here"
Pull Request Test Coverage Report for Build 6612398046
💛 - Coveralls |
@codeZeilen tests failing due to compiledmethod not knowing parseTree which uses |
@JoeAtHPI Ohm should be able to handle this. You may want to look at BPSourceMapping and BPSourceMapNode and the place where they are used. You should be able to create a source map with If you can really not get this to work you may add the dependency to RBParser (but, as we have Ohm it would be preferable to avoid this additional dependency to a parser). :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First noted/questions. Will come back later for more. :)
@@ -1,27 +0,0 @@ | |||
*Babylonian-ExampleMining-Core-override |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several of these example mining methods disappeared. Is this intentional? Where did they go? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, will add them back later!
@@ -5,7 +5,7 @@ | |||
A Smalltalk implementation of the Babylonian Programming System. | |||
|
|||
## How to install | |||
1. Get [a recent Squeak][squeakorg] | |||
1. Get [a recent trunk Squeak][squeakorg] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is trunk needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will revert this
@@ -15,11 +15,6 @@ Metacello new | |||
repository: 'github://hpi-swa-lab/babylonian-programming-smalltalk:main/packages'; | |||
load. | |||
``` | |||
4. (Recommended) Disable the preference for notifications on saving methods with styles. This prevents that you will be asked whether you want to save style information whenever you save a method with probes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, i think the readme got a bit messed up when dev was merged
private | ||
allBabylonianInternalClasses | ||
^ #('Babylonian-Core' 'Babylonian-Compiler' 'Babylonian-UI' 'Babylonian-ProbeLog') | ||
inject: OrderedCollection new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use gather for this. :)
Instance Probes are a new kind of annotation which can be added to instance variable names in class' definitions.
They will add assignment probes throughout all methods of the responding class in which the variable gets directly assigned. For example, selecting 'foo' will add probes to all lines containing 'foo := ' instead of 'foo: '. Shadowing ignored.
In the instance probe, which gets displayed in class' defintions, users will see the chronologically ordered trace of all values of the added assignment probes. When deleting one of those linked probes, its values also disappear from the instance probe trace. Deleting the instance probe will delete the linked probes.
This feature used to be achieved by manually adding probes to only assignments and displaying the example in the ProbeLog.
Future Todos are: