Added Preprocessing Bundle to ML_Core #25
Conversation
|
@RogerDev Please review |
There was a problem hiding this comment.
@vzeufack Good code and testing! There are a few merge conflicts and minor typos. Please resolve.
Preprocessing/StandardScaler.ecl
Outdated
| SHARED numberLayout := Preprocessing.Types.numberLayout; | ||
|
|
||
| /** | ||
| * Computes averages and stdevs for each feature in baseData. |
There was a problem hiding this comment.
Please try to void shorthand: stdevs = standard deviation (stdevs)
Preprocessing/LabelEncoder.ecl
Outdated
| RETURN Result; | ||
| ENDMACRO; | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Remove line 59. It looks like a leftover from a merge conflict
| $.TestOneHotEncoder.RunOneHotEncoderTests; | ||
| $.TestStandardScaler.RunStandardScalerTests; | ||
| $.TestMinMaxScaler.RunMinMaxScalerTests; | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please resolve the merge conflict
| $.TestAreEqualRows.TestDifferentRows(); | ||
|
|
||
| $.TestCompare.TestEqualData(); | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please resolve the merge conflict
| END; | ||
|
|
||
| /** | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please resolve the merge conflict
| PROJECT(ROWS(LEFT), XF(LEFT))); | ||
|
|
||
| #UNIQUENAME(comparisonResult) | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
Please resolve the merge conflict
vzeufack
force-pushed
the
master
branch
5 times, most recently
from
e6dff78 to
92ac0e2
Compare
There was a problem hiding this comment.
Some minor typos need correction. A few descriptions need more details.
Great job! @vzeufack
Preprocessing/LabelEncoder.ecl
Outdated
| * </pre> | ||
| */ | ||
| EXPORT GetMapping(key) := FUNCTIONMACRO | ||
| IMPORT Preprocessing.Utils.LabelEncoder; |
There was a problem hiding this comment.
It may cause broken code. please use relative path.
Preprocessing/LabelEncoder.ecl
Outdated
| * <p> Data with categorical values replaced by numbers. | ||
| */ | ||
| EXPORT Encode(dataToEncode, key) := FUNCTIONMACRO | ||
| IMPORT Preprocessing.Utils; |
There was a problem hiding this comment.
It may cause broken code. please use relative path.
Preprocessing/LabelEncoder.ecl
Outdated
| * <p> Data with categorical values replaced by their original labels. | ||
| */ | ||
| EXPORT Decode(dataToDecode, encoderKey) := FUNCTIONMACRO | ||
| IMPORT Preprocessing.Utils; |
There was a problem hiding this comment.
It may cause broken code. please use relative path.
| IMPORT STD; | ||
| IMPORT $.Files; | ||
|
|
||
| spray := STD.File.SprayDelimited('192.168.56.101', |
There was a problem hiding this comment.
Please abstract the IP address
| IMPORT STD; | ||
| IMPORT $.Files; | ||
|
|
||
| STD.File.SprayDelimited('192.168.56.101', |
There was a problem hiding this comment.
Please abstract the IP address
| * | ||
| * @param partialKey: same record structure as the key (see below). | ||
| * <p> Mapping between feature names and categories. | ||
| * Some names are mapped to empty categories such that |
There was a problem hiding this comment.
Please add a description for the case where the names are mapped to non-empty categories.
Preprocessing/MinMaxScaler.ecl
Outdated
| t_FieldReal := MLC.types.t_FieldReal; | ||
|
|
||
| /** | ||
| * shifts the values in a range [min, max]. |
Preprocessing/MinMaxScaler.ecl
Outdated
|
|
||
|
|
||
| /** | ||
| * scales the data using the following formula: |
Preprocessing/OneHotEncoder.ecl
Outdated
| END; | ||
|
|
||
| /** | ||
| * Produces a mapping between numbers when encoded to numbers when decoded. |
There was a problem hiding this comment.
Please rephrase this line for better description of the function.
Preprocessing/StratifiedSplit.ecl
Outdated
| END; | ||
|
|
||
| /** | ||
| * Determines y stats from full data. |
There was a problem hiding this comment.
Please explain y stats
|
Is this branch going to be merged? Analytics would like to use the preprocessing module to prepare data for deep learning training. I have cloned @vzeufack 's repository yet run into this error when trying to import the module:
Not sure if merging the branch would resolve this issue or not. Please advise! |
|
@Zelazny7 If ML_Core bundle is already installed previously, it may conflict with the downloaded ML_Core bundle. Rename the downloaded bundle should solve the issue. Please let me know if anything is unclear. |
The current version of the Preprocessing Bundle includes: