-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-30691 Group functions with related activity in metrics page #18105
HPCC-30691 Group functions with related activity in metrics page #18105
Conversation
https://track.hpccsystems.com/browse/HPCC-30691 |
23618b0
to
297f11c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GordonSmith marked as approved. Just saw a couple minor things, a commented out line in metricGraph & a typo in a symbol name
Currently they can display anywhere in a group on their own Signed-off-by: Gordon Smith <[email protected]>
297f11c
to
82ba015
Compare
function shape(kind: string) { | ||
return KindShape[kind] || "rectangle"; | ||
function shape(v: IScope) { | ||
return TypeShape[v.type] ?? KindShape[v.kind] ?? "rectangle"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeclrsg - should have been v.Kind
Currently they can display anywhere in a group on their own
Type of change:
Checklist:
Smoketest:
Testing: