Move the end span before the span finish logging

Signed-off-by: Gavin Halliday <[email protected]>
hpcc-systems · Nov 21, 2023 · b55ef92 · b55ef92
1 parent 4d22daf
commit b55ef92
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/system/jlib/jtrace.cpp b/system/jlib/jtrace.cpp
@@ -218,14 +218,13 @@ class CSpan : public CInterfaceOf<ISpan>
 {
 public:
     CSpan() = delete;
-    ~CSpan()
+
+    virtual void beforeDispose() override
     {
+        //Record the span as complete before we output the logging for the end of the span
         if (span != nullptr)
             span->End();
-    }
 
-    virtual void beforeDispose() override
-    {
         if (queryInternalTraceManager().logSpanFinish())
         {
             StringBuffer out;