Skip to content

Commit

Permalink
HPCC-33191 Simplify roxie span names
Browse files Browse the repository at this point in the history
- Removes roxie span name prefix
- Anotates roxie spans with queryset name

Signed-off-by: Rodrigo Pastrana <[email protected]>
  • Loading branch information
rpastrana committed Jan 21, 2025
1 parent 5d58d01 commit a491637
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions roxie/ccd/ccdlistener.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1566,12 +1566,8 @@ class RoxieProtocolMsgContext : implements IHpccProtocolMsgContext, public CInte

ensureContextLogger();

const char * spanQueryName = !isEmptyString(queryName) ? queryName : "run_query";
StringBuffer spanName(querySetName);
if (spanName.length())
spanName.append('/');
spanName.append(spanQueryName);
requestSpan.setown(queryTraceManager().createServerSpan(spanName, allHeaders, flags));
requestSpan.setown(queryTraceManager().createServerSpan(!isEmptyString(queryName) ? queryName : "run_query", allHeaders, flags));
requestSpan->setSpanAttribute("queryset.name", querySetName);
logctx->setActiveSpan(requestSpan);

const char * globalId = requestSpan->queryGlobalId();
Expand Down

0 comments on commit a491637

Please sign in to comment.