adjust retry counts

howardchung · Mar 17, 2024 · f131325 · f131325
1 parent dad2c7a
commit f131325
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/server/vm/base.ts b/server/vm/base.ts
@@ -425,7 +425,7 @@ export abstract class VMManager {
           // Do a minimum # of retries to give reboot time
           return [vmid, retryCount, false].join(',');
         }
-        if (retryCount % 100 === 0) {
+        if (retryCount % 150 === 0) {
           console.log(
             '[CHECKSTAGING] %s: %s poweron, attach to network',
             this.getPoolName(),
@@ -434,15 +434,15 @@ export abstract class VMManager {
           this.powerOn(vmid);
           //this.attachToNetwork(vmid);
         }
-        if (retryCount % 150 === 0) {
+        if (retryCount % 180 === 0) {
           console.log('[CHECKSTAGING]', this.getPoolName(), 'giving up:', vmid);
           redisCount('vBrowserStagingFails');
           await redis?.lpush('vBrowserStageFails', vmid);
           await redis?.ltrim('vBrowserStageFails', 0, 24);
           await this.resetVM(vmid);
           // await this.terminateVMWrapper(vmid);
         }
-        if (retryCount >= 150) {
+        if (retryCount >= 180) {
           throw new Error('too many attempts on vm ' + vmid);
         }
         // Fetch data on first attempt

diff --git a/server/vmWorker.ts b/server/vmWorker.ts
@@ -85,7 +85,8 @@ app.get('/isFreePoolFull', async (req, res) => {
   const freePools = Object.values(vmManagers).filter((mgr) => {
     return (
       mgr?.getIsLarge() === false &&
-      mgr?.getRegion() === config.DEFAULT_VM_REGION
+      mgr?.getRegion() === config.DEFAULT_VM_REGION &&
+      mgr?.getLimitSize() > 0
     );
   });
   const fullResult = await Promise.all<Boolean>(