Fix ohsomeNow URL link on Bar Chart click in Partner Stats page #6703
+24
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Break ohsomeNow env vars into `OHSOME_STATS_BASE_URL` & `OHSOME_STATS_API_URL` - Update `example.env`
royallsilwallz
force-pushed
the
fix/6681-ohsomenow-chart-click-crash-issue
branch
from
6928e96 to
cb84987
Compare
|
royallsilwallz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issue
Describe this PR
This PR resolves the wrong URL for opening ohsomeNow stats page on Bar chart label click.
Changes
OHSOME_STATS_BASE_URL&OHSOME_STATS_API_URLexample.envhashtagin the ohsomeNow redirect URLAdditional Requirements
This PR requires some environment variables to be changed on the CI / development.
Following env vars should be altered -
cc - @dakotabenjamin