Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

View Task Instructions without login #6592

Merged
merged 13 commits into from
Nov 13, 2024
Merged

View Task Instructions without login #6592

merged 13 commits into from
Nov 13, 2024

Commits on Nov 11, 2024

  1. Create different route paths for Instructions & Contributions 

    - Add `tabname` param to `/projects/:id/` route
- Change local tab state to route param tabname
- Remove footer for instructions & contributions route
    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    571f76d View commit details
    Browse the repository at this point in the history

  2. Add button to navigate to Instructions page from Project Detail page

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ca077ff View commit details
    Browse the repository at this point in the history

  3. Show Project Detail Map instead of Task Map when not logged in 

    - Enable task api call only when logged in
- Add `taskBordersOnly` props for directly zooming to tasks in `ProjectDetailMap`
- Zoom to task border initially
    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e372d2d View commit details
    Browse the repository at this point in the history

  4. Change View Instructions button to link

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    8b7da1b View commit details
    Browse the repository at this point in the history

  5. Show only Instructions tab when not logged in

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ef51caa View commit details
    Browse the repository at this point in the history

  6. Navigate to login when Map a Task button is clicked without login

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5c4ef1b View commit details
    Browse the repository at this point in the history

  7. Navigate to login on route is not public

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    69e4e8e View commit details
    Browse the repository at this point in the history

  8. Redirect back to Instructions page after login from Map a Task

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cebb6ed View commit details
    Browse the repository at this point in the history

  9. Show Permission Error when trying to access Private Project Instructions

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e5f8083 View commit details
    Browse the repository at this point in the history

  10. Fix search tasks functionality not working issue

    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a71a404 View commit details
    Browse the repository at this point in the history

  11. Fix test cases failure for Task page 

    - Reason: Due to change in Tab selection logic with url routes
    @royallsilwallz
    royallsilwallz committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    26ef91e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Redirect to Tasks & Instructions page only when user clicks Contribute 

    - Fix redirect issue from tasks page to instructions and vice versa
- Preserve respective page route on reload
    @royallsilwallz
    royallsilwallz committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b2a90c5 View commit details
    Browse the repository at this point in the history

  2. Add from state to MemoryRouter in Tasks page test cases 

    - Fix test case failure for redirect issue in task page
    @royallsilwallz
    royallsilwallz committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    cb58a09 View commit details
    Browse the repository at this point in the history