fix(kubernetes): non-string annotation values cause the annotation map in a manifest's Go representation to be empty #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billimek
approved these changes
Jan 10, 2024
guido9j
approved these changes
Jan 10, 2024
alice485
deleted the
CN-2578-go-clouddriver-metadata-annotations-max-256-k-size-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes expects manifest annotations to be a map with string values. This PR resolves the bug indirectly discovered in this issue by forcing all non-string annotations to
stringtype when converting to a kubernetesunstructured.Unstructuredobject.Failure because annotations were getting cleared out, thus
strategy.spinnaker.io/replacewas missing:Successful deployment after fix: