-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backups: add reference to backup create automatic action #37309
Conversation
It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the |
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughA new section titled "Creating a backup automation using the backup action" was added to the backup documentation file. This section provides guidance on manually configuring backup automation using the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CT as Calendar Trigger
participant NAS as NAS System
participant BA as Backup Automation
U->>BA: Initiate backup configuration using backup.create_automatic
BA->>CT: Setup schedule (e.g., calendar trigger)
CT->>NAS: (Optional) Activate NAS before backup
NAS->>BA: Confirm readiness for backup
BA->>U: Backup process initiated
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_includes/common-tasks/backups.md (1)
78-83
: Consider Adding a YAML Example for ClarityWhile the narrative explanation is good, including a short YAML snippet example could help users quickly grasp how to integrate the
backup.create_automatic
action into their automation configurations. This addition would provide a practical reference point and improve the documentation’s usability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_includes/common-tasks/backups.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (1)
source/_includes/common-tasks/backups.md (1)
78-83
: New Backup Automation Section is Well-StructuredThe new section "### Creating a backup automation using a backup action" is clear and provides helpful guidance on using the
backup.create_automatic
action. It fits well with the existing documentation style and informs users about customizing their backup automations beyond the default UI options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_includes/common-tasks/backups.md (1)
82-83
: Address Repeated Terminology in Service Call DescriptionThe sentence on these lines has a slight redundancy where the term "action" is repeated:
Current text:
Using the {% my developer_call_service service="backup.create_automatic" %} action in your own automation allows you to create automated backups on any schedule you like, or even add conditions and actions around it.
Suggestion:
Replace the duplicated "action" with "service" to enhance clarity. For example:-Using the {% my developer_call_service service="backup.create_automatic" %} action in your own automation allows you to create automated backups on any schedule you like, or even add conditions and actions around it. +Using the {% my developer_call_service service="backup.create_automatic" %} service in your own automation allows you to create automated backups on any schedule you like, and even add conditions and additional actions.This minor edit addresses the duplication flagged by static analysis and improves the readability of the documentation.
🧰 Tools
🪛 LanguageTool
[duplication] ~82-~82: Possible typo: you repeated a word.
Context: ...action. Using the {% my developer_call_service service="backup.create_automatic" %} action in ...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_includes/common-tasks/backups.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_includes/common-tasks/backups.md
[duplication] ~82-~82: Possible typo: you repeated a word.
Context: ...action. Using the {% my developer_call_service service="backup.create_automatic" %} action in ...
(ENGLISH_WORD_REPEAT_RULE)
🔇 Additional comments (1)
source/_includes/common-tasks/backups.md (1)
78-81
: Clear and Informative Section AdditionThe new "Creating a backup automation using a backup action" section is organized and provides clear guidance on manually configuring backup automation using the
backup.create_automatic
action. The instructions and reference to the integration are consistent with the rest of the document.
Co-authored-by: Joost Lekkerkerker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_includes/common-tasks/backups.md (1)
78-83
: Enhance Documentation Clarity for Backup AutomationThe newly added section "Creating a backup automation using the backup action" clearly demonstrates how users can configure their own backup automation using the
[backup.create_automatic]
action. This addition aligns well with the PR objectives, providing useful information for advanced backup setups.A couple of nitpicks for readability:
On line ~82, the sentence beginning with "Using the {% my developer_call_service service="backup.create_automatic" %} action in your own automation…" might be improved to avoid a potential duplicate usage of the word "action." Consider rephrasing it to something like:
-Using the {% my developer_call_service service="backup.create_automatic" %} action in your own automation allows you to create automated backups on any schedule you like, or even add conditions and actions around it. +Using the {% my developer_call_service service="backup.create_automatic" %} service in your automation allows you to create automated backups on any schedule, and even add specific conditions or additional actions.This adjustment ensures smoother reading and avoids redundancy.
🧰 Tools
🪛 LanguageTool
[duplication] ~82-~82: Possible typo: you repeated a word.
Context: ...action. Using the {% my developer_call_service service="backup.create_automatic" %} action in ...(ENGLISH_WORD_REPEAT_RULE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_includes/common-tasks/backups.md
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_includes/common-tasks/backups.md
[duplication] ~82-~82: Possible typo: you repeated a word.
Context: ...action. Using the {% my developer_call_service service="backup.create_automatic" %} action in ...
(ENGLISH_WORD_REPEAT_RULE)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
* Backups: add reference to backup create automatic action * Add my link * Update source/_includes/common-tasks/backups.md Co-authored-by: Joost Lekkerkerker <[email protected]> --------- Co-authored-by: Franck Nijhof <[email protected]> Co-authored-by: Joost Lekkerkerker <[email protected]>
Proposed change
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
Summary by CodeRabbit