-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ultraloq from the WWHA partner program #28166
Conversation
The wiki page should also be updated. Maybe make a pull request there for a change as well? I do not want to make any commits as I am unsure exactly what removing the WWHA stuff should look like and if any warning should be in place? Maybe someone more experienced with HA wiki editing could do a PR? |
@TheOneOgre Can you please link me to that wiki page? I wouldn't know what you're referring to, sorry |
Honestly I was basing this off an edit I made but it doesn't seem like all the data is there such as the work with home assistant badge so I'm not exactly sure how you go about removing it but this is as close as I got. https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/ultraloq.markdown |
Seems odd to me that the documentation and branding is removed, but not the virtual integration. Did you miss that one? ../Frenck |
We were discussing that here. Was wondering what your thoughts on what to do are? |
Well, this is not opinionated from my review point of view. Every integration needs documentation and preferably brand assets; otherwise, it looks weird in the UI, and a user won't be able to find any information about the integration shown in the UI. The political question/discussion on this: I have no opinion. |
I did miss that, indeed. Thanks! Taking care now. |
@frenck Removing the virtual integration is home-assistant/core#96355 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @b-uwe 👍
Proposed change
Remove Ultraloq from the WWHA partner program
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.