Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ultraloq from the WWHA partner program #28166

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

b-uwe
Copy link
Contributor

@b-uwe b-uwe commented Jul 11, 2023

Proposed change

Remove Ultraloq from the WWHA partner program

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo labels Jul 11, 2023
@b-uwe b-uwe marked this pull request as ready for review July 11, 2023 02:19
@b-uwe b-uwe requested a review from frenck July 11, 2023 02:19
@TheOneOgre
Copy link
Contributor

TheOneOgre commented Jul 11, 2023

The wiki page should also be updated. Maybe make a pull request there for a change as well? I do not want to make any commits as I am unsure exactly what removing the WWHA stuff should look like and if any warning should be in place? Maybe someone more experienced with HA wiki editing could do a PR?

@b-uwe
Copy link
Contributor Author

b-uwe commented Jul 11, 2023

The wiki page should also be updated.

@TheOneOgre Can you please link me to that wiki page? I wouldn't know what you're referring to, sorry

@TheOneOgre
Copy link
Contributor

The wiki page should also be updated.

@TheOneOgre Can you please link me to that wiki page? I wouldn't know what you're referring to, sorry

Honestly I was basing this off an edit I made but it doesn't seem like all the data is there such as the work with home assistant badge so I'm not exactly sure how you go about removing it but this is as close as I got. https://github.com/home-assistant/home-assistant.io/blob/current/source/_integrations/ultraloq.markdown

@frenck
Copy link
Member

frenck commented Jul 11, 2023

Seems odd to me that the documentation and branding is removed, but not the virtual integration. Did you miss that one?

../Frenck

@TheOneOgre
Copy link
Contributor

TheOneOgre commented Jul 11, 2023

Seems odd to me that the documentation and branding is removed, but not the virtual integration. Did you miss that one?

../Frenck

We were discussing that here. Was wondering what your thoughts on what to do are?

@frenck
Copy link
Member

frenck commented Jul 11, 2023

Well, this is not opinionated from my review point of view. Every integration needs documentation and preferably brand assets; otherwise, it looks weird in the UI, and a user won't be able to find any information about the integration shown in the UI.

The political question/discussion on this: I have no opinion.

@b-uwe
Copy link
Contributor Author

b-uwe commented Jul 11, 2023

Seems odd to me that the documentation and branding is removed, but not the virtual integration. Did you miss that one?

I did miss that, indeed. Thanks! Taking care now.

@b-uwe
Copy link
Contributor Author

b-uwe commented Jul 12, 2023

@frenck Removing the virtual integration is home-assistant/core#96355
Thanks once more for making me aware I forgot that one!

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @b-uwe 👍

@frenck frenck merged commit a7c0d21 into home-assistant:current Jul 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
@b-uwe b-uwe deleted the unpartner_ultraloq branch July 18, 2023 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants