Include last 30 min and 2 hours into history page

[tasomaniac]

Breaking change

No

Proposed change

The change adds last 30 min and 2 hours options. Based on the feedback on this PR, I can amend to include other options.

Screenshots

The time of the computer was 9:11 PM when this was taken.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests
• Improvement of existing feature

Example configuration

N/A

• This PR is related to issue or discussion: https://community.home-assistant.io/t/wth-cant-we-customize-history-ranges/471723/10

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works (couldn't find existing tests, let me know if they exist and I will add more to cover the new options)

[home-assistant]

Hi @tasomaniac

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[silamon]

There's a related PR in the queue: #23362. I'll link it up here for visibility.
What's the reasoning to add 30 minutes and 2 hours specific?

[tasomaniac]

Those are what I thought would be useful. But as I said in the description, I'm open to opinions. Please share yours.

• 30 minutes to quickly check the latest
• 2 hours to check more

I didn't want to put more to not clutter the UI. Plus, it can be easily adjusted below in the time picker.

[marcinbauer85]

Thanks @tasomaniac for this addition, but I'm afraid there will be more requests to add: 1hour, 4hours etc. which will blow up this selector. The date/time picker needs a bigger UX revamp especially for mobile, that's why I would hold off for now with adding more presets.

[tasomaniac]

Checking something recent takes a lot of time and clicks. By default it starts from yesterday, so you first select today and then select pm, then select the hour closer. It's a real pain for me as a user right now.

I would recommend at least adding one of these so that adjusting to whatever recent hour gets easier.

I understand the idea of redesigning the whole thing but that will just take much more time.

[silamon]

That's amazon way of dealing with the same (two tabs with 2 buttons visible on each tab):

Edit: On mobile the buttons are replaced with a dropdown.

[marcinbauer85]

@silamon that's nice, but we also use those presets in other areas, which don't have UI space for a button group. Like in the Statistics card 23794

[tasomaniac]

I'm not sure if this is the right place to discuss what could be the next redesign of this page. But the fact that it is already controversial just proves my point that the users like me will have to wait for very long for this redesign and will continue to suffer from inaccessibility to look for recent data.

[boern99]

Tried to improve the situation by using plus and minus zoom buttons #23358 in combination with additional ranges #23362. Think that the two commits together build a compromise between easy implementation, maximum flexibility, clarity and good usability. The maximum zoom range for the buttons is 2 hours: never thought to need a lower range as history only uses 5Minute-intervals and charts itself can now be zoomed to see more details …

[marcinbauer85]

I will be doing a user test to define the most commonly voted ranges that we can agree upon for this picker. Please hold on till we get the results.