-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix setting MQTT socket buffer size with WebsocketWrapper #117672
Conversation
Hey there @emontnemery, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I have no city power right now due to the storm in Houston so I have no way to test this unfortunately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests needed, rest looks good
@@ -99,7 +99,7 @@ | |||
TIMEOUT_ACK = 10 | |||
RECONNECT_INTERVAL_SECONDS = 10 | |||
|
|||
type SocketType = socket.socket | ssl.SSLSocket | Any | |||
type SocketType = socket.socket | ssl.SSLSocket | Any | "mqtt.WebsocketWrapper" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need the quotes anymore, and may need an different rc/patch version of this PR as well as a dev version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the cleanest is to take out the typing change for the patch and add it in a future PR so we can do a cherry pick.
I will write tests once I have stable power
@bdraco It worked. Thanks. |
eclipse-paho/paho.mqtt.python#843 opened to solve the issue upstream as well so we can remove this workaround in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thanks @bdraco 👍
Thanks Will merge this now and open a new PR to adjust the typing in 55841b9 since we want to avoid the conflict for backport |
this was removed from #117672 so it could be cherry-picked cleanly for backport
Proposed change
Fix setting MQTT socket buffer size with
WebsocketWrapper
until eclipse-paho/paho.mqtt.python#843 can be usedrelated issue #115958 (comment) #117714 (comment)
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: