[WIP] Divide the single file into separate files as modules #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
changed the title
|
I think dividing modules is a good idea. The requirements I need are the following.
When this module dividing is completed, I'd like to release version 1.0. I just created a 1.0 branch so could you change the base branch of this PR? |
|
@hokaccha That sound fine to me as well. I will continue finishing this patch then, and let you know when it's ready ;) |
watilde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address to this topic, I open this pull request to show diff. Potentially, this could be closed depending on the conclusion of the discussion on the issue.
Note - since a location of a bin file was changed in this PR, we need to update an installer link:
git.io/nodebrewif we merge this.