Font pixel snap #2143
Merged
Font pixel snap #2143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm okay with squashing this PR into a single commit (I thought I'd be able to do it on PR creation, but apparently I can't). The squash option probably resides in the "Merge PR" submenu. |
hoffstadt
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: Ability to enable pixel snap on fonts
assignees: @hoffstadt
Description:
ImGui provides a way for font characters to be snapped to whole-pixel boundaries - this is useful when you compute text sizes with monospace fonts by just multiplying character width by the text length. Text width returned by
get_text_sizeis automatically rounded so you often can't rely on it with non-snapped fonts; withpixel_snapH=true, though,get_text_sizedoesn't lose any fractional values (because they are always integer).With this fix, the pixel snap parameter gets exposed in DPG API so one can turn it on.
Concerning Areas:
None.