fix (mvFileDialog): Need an INCREF on cancel_callback #2148

hoffstadt · Aug 18, 2023 · c53a4c5 · c53a4c5
1 parent 4b0b913
commit c53a4c5
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/src/mvFileDialog.cpp b/src/mvFileDialog.cpp
@@ -187,7 +187,18 @@ void mvFileDialog::handleSpecificKeywordArgs(PyObject* dict)
 		_max_size = { (float)max_size[0], (float)max_size[1] };
 	}
 
-	if (PyObject* item = PyDict_GetItemString(dict, "cancel_callback")) _cancelCallback = item;
+	if (PyObject* item = PyDict_GetItemString(dict, "cancel_callback"))
+	{
+		Py_XDECREF(_cancelCallback);
+
+		if (item == Py_None)
+			_cancelCallback = nullptr;
+		else
+		{
+			Py_XINCREF(item);
+			_cancelCallback = item;
+		}
+	}
 
 }