Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#540 Fixed clickability issue with XAI Button #554

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

Keszwel
Copy link
Collaborator

@Keszwel Keszwel commented Dec 10, 2024

fixed The "Dashboard" should only be clickable when an actual dashboard is available #540
Solution:
Set a default value to dashboard_status and made Check in ExplanationRazorShort to see if dashboard exists.

Out of Scope:
Dashboard loading times

@AlexanderZender
Copy link
Collaborator

Works, but we do not want to send the dashboard path to the frontend.
Instead use a placeholder :
Available
NotAvailable

@AlexanderZender
Copy link
Collaborator

I think you need to remerge the main branch.
A lot of file changes may not be needed?

@Keszwel
Copy link
Collaborator Author

Keszwel commented Jan 29, 2025

merged master into branch. Now its up to date

@AlexanderZender AlexanderZender merged commit dfc204c into main Jan 30, 2025
@AlexanderZender AlexanderZender deleted the 540-fix-XAI-dashboard-button branch January 30, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants