Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate launch4j into maven build process #1200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ralfgerlich
Copy link

Currently, there are two open issues (#991 and #670), which seem to be related to non-up-to-date launch4j artefacts (Digital.exe, Digital_nod3d.exe). It seems that in the current build process these two artefacts are generated manually and imported into the distribution subdirectory.

There is a maven plugin (https://github.com/orphan-oss/launch4j-maven-plugin) that allows running launch4j from maven, and thus possibly also in the CI/CD pipeline.

This PR introduces launch4j into the Maven build, building both exes in the target directory and pulling them in appropriately for assembly. It also fixes a few warnings from the assembly plugin regarding superfluous slashes in <outputDirectory> settings.

So far, I have tested it successfully on a Windows 11 Professional install (Version 22H2, build 22621.2283) with openjdk 17.0.8.1 (Microsoft Build). The generated launchers find my installed JRE and run Digital. mvn verify also runs through, which to me would imply that Digital would be usable with this JRE version.

Some of the configuration for launch4j had to be adapted, as there have been changes leading up to Version 3.50:

  • <path> needs to be explicitly set, with the default suggested by launch4j being %JAVA_HOME%;%PATH%.
  • <bundledJre64Bit> and <runtimeBits> have been removed and replaced by <requires64Bit>, which is false by default, but was kept for documentation purposes.
  • <bundledJreAsFallback> had been removed, it had been set to false anyway as no JRE is included. If a JRE were to be included, changing the <path> setting appropriately would introduce the fallback.
  • <jdkPreference> has been replaced by <requiresJdk>, which is false by default.

@ralfgerlich
Copy link
Author

Just checked with Adoptium Eclipse Temurin 17.0.8.1+1 (after uninstalling the Microsoft openjdk), and the exes also work (even for opening .dig files by associating them with Digital.exe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant