Add ability to deliver assets from byocdn domain

[sdmcraft]

Test URLs:

• Before: https://main--franklin-assets-selector--hlxsites.hlx.live/same-domain-delivery
• After: https://gems--franklin-assets-selector--hlxsites.hlx.live/same-domain-delivery

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

• Re-run PSI checks
• Re-sync branch

Commits

• 51604ea ✅ (latest)
• a9381c1 ✅
• eb21d12 ✅
• 0a074fa ✅
• 4d3348a ✅
• c7b5cd4 ✅
• a39e923 ✅
• 3ecdb01 ✅
• add513c ✅

[actinium15]

Thanks foe this, @sdmcraft!

Do you think there's value in a reverse pattern as well? (where AEM Assets sidekick plugin has an additional configuration to specify the custom domain to include in the urls it adds to the doc, and the custom domain is swapped for delivery domain when the site is accessed from .hlx. domains)

[actinium15]

Think we could use Polaris urls for holding configs instead of relying on competitor 😅

[sdmcraft]

Using Polaris now for delivering configs and works great 👍

[sdmcraft]

Do you think there's value in a reverse pattern as well? (where AEM Assets sidekick plugin has an additional configuration to specify the custom domain to include in the urls it adds to the doc, and the custom domain is swapped for delivery domain when the site is accessed from .hlx. domains)

That's a good idea indeed. It would mean less custom work, just specify the prod domain in AS config and the AS addon swaps the domains while copy pasting in Word doc itself. The assumption would be that you should only do this after you have setup the routing in byocdn to Polaris origin so that delivery urls with byocdn domain are able to deliver assets.

I think I can even omit swapping back to delivery urls as the asset delivery via byocdn would still work even for pages served from the internal hlx domains.

[actinium15]

The assumption would be that you should only do this after you have setup the routing in byocdn to Polaris origin so that delivery urls with byocdn domain are able to deliver assets.

...and we can forego that assumption if we implement a reverse of what this PR does (i.e., until byocdn is configured to front Polaris OOTB domain, the swapping will continue).

In my mind that'd mean lookup of img/picture/video tags in render-blocking won't be needed on 'production' websites - not sure if it is micro/meaningless optimization, though.

can even omit swapping back to delivery urls as the asset delivery via byocdn would still work even for pages served from the internal hlx domains.

+1, subject to the assumption above - though my hunch is that getting customer to implement the routing to Polaris domain in byocdn _before go-live/CDN-cutover to Franklin site_ might prove challenging.

[sdmcraft]

I am thinking slightly differently on this one. Basically have the same domain asset delivery as an "opt-in" else the default is as now i.e. assets get delivered for delivery-pXX-eYY.
Else for swapping back, we need to identify which urls needs rewrite (probably doable by looking at pattern like /adobe/assets/urn:aaid:aem.. ) and keep track of back to what (which delivery-pXX-eYY..) and also have some flag to indicate that byocdn is set and swap back is no longer needed. And to add to that, a requirement to add this swap back logic to any EDS site's git repo..

though my hunch is that getting customer to implement the routing to Polaris domain in byocdn before go-live/CDN-cutover to Franklin site might prove challenging

Yes, but I think we can't work around that since we are tackling this outside the the pipeline that generates the markup

[aem-code-sync]

	Page	Scores	Audits	Google
M	/same-domain-delivery		Unable to process request. Please wait a while and try again.
D	/same-domain-delivery		Unable to process request. Please wait a while and try again.

[sdmcraft]

Closing this and handling this on the Asset selector end wherein the authoring flow, the url copied over to Word/Google doc can be configured to have site's byocdn domain.