-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to deliver assets from byocdn domain #92
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks foe this, @sdmcraft!
Do you think there's value in a reverse pattern as well? (where AEM Assets sidekick plugin has an additional configuration to specify the custom domain to include in the urls it adds to the doc, and the custom domain is swapped for delivery domain when the site is accessed from .hlx. domains)
tools/sidekick/config.json
Outdated
@@ -5,7 +5,7 @@ | |||
"id": "asset-library", | |||
"title": "AEM Assets Library", | |||
"environments": ["edit"], | |||
"url": "https://experience.adobe.com/solutions/CQ-assets-selectors/static-assets/resources/franklin/asset-selector.html", | |||
"url": "https://experience.adobe.com/solutions/CQ-assets-selectors/static-assets/resources/franklin/asset-selector.html?extConfigUrl=https%3A%2F%2Fhelix-asset-selector-configs.netlify.app%2Fconfig-gems.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we could use Polaris urls for holding configs instead of relying on competitor 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Polaris now for delivering configs and works great 👍
That's a good idea indeed. It would mean less custom work, just specify the prod domain in AS config and the AS addon swaps the domains while copy pasting in Word doc itself. The assumption would be that you should only do this after you have setup the routing in byocdn to Polaris origin so that delivery urls with byocdn domain are able to deliver assets. I think I can even omit swapping back to delivery urls as the asset delivery via byocdn would still work even for pages served from the internal hlx domains. |
...and we can forego that assumption if we implement a reverse of what this PR does (i.e., until byocdn is configured to front Polaris OOTB domain, the swapping will continue). In my mind that'd mean lookup of img/picture/video tags in render-blocking won't be needed on 'production' websites - not sure if it is micro/meaningless optimization, though.
+1, subject to the assumption above - though my hunch is that getting customer to |
I am thinking slightly differently on this one. Basically have the same domain asset delivery as an "opt-in" else the default is as now i.e. assets get delivered for delivery-pXX-eYY.
Yes, but I think we can't work around that since we are tackling this outside the the pipeline that generates the markup |
|
Closing this and handling this on the Asset selector end wherein the authoring flow, the url copied over to Word/Google doc can be configured to have site's byocdn domain. |
Test URLs: