-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable optimizer in vite-node for vite 6 compat #756
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
❌ Deploy Preview for histoire-site failed.
|
❌ Deploy Preview for histoire-controls failed.
|
❌ Deploy Preview for histoire-examples-svelte3 failed.
|
❌ Deploy Preview for histoire-examples-vue3 failed.
|
commit: histoire
@histoire/app
@histoire/controls
@histoire/plugin-nuxt
@histoire/plugin-percy
@histoire/plugin-screenshot
@histoire/plugin-svelte
@histoire/plugin-vue
@histoire/plugin-vue2
@histoire/shared
@histoire/vendors
|
Netlify is failing with the following error:
I didn't change anything related to pnpm or node version, so probably it's not broken by this PR. |
Description
This PR adds
optimizeDeps.include = []
andoptimizeDeps.noDiscovery = true
when using vite-node to make histoire pass the tests with Vite with the Environment API PR merged (vitejs/vite#16471).Setting these options is recommended by vite-node. (
optimizeDeps.disable
is now deprecated and replaced with the options above.)optimizeDeps.noDiscovery
was added in Vite 5.1, but given that histoire works without that setting for Vite pre-6, using it should be fine.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).