feat(percy): support builder for options and adding types #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add percy and puppeteer types, convert options to also have a builder where we can decide what options we want to use depending on the variant we are checking, add a new
beforeSnapshot
in case we want to make any change to thepage
.It would be nice if the attributes for Story and Variants could be provided, it would be cool to add some identifier to them or to group them in a way.
myDataGroup
could be provided in thepayload
when using for options.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).I think #373 might be able to be closed, there's already that functionality, I think with
beforeSnapshot
we have more flexibility to wait for things to be ready.