You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issue when users use histoire using relative paths in a subdirectory.
Workaround is still <Story :layout="{ type: 'grid', width: '75%' }"> as mentioned in #635
Description
This enhances recent PR #652 that made break our histoire setup while using a relative path. We use base = "" however run it in a subfolder so adding the '/' actually breaks it, see image. When I fixed it in my local node_modules folder the code committed solved it.
Additional context
N.B. I am using the nuxt extension. Without this fix I get the following error:
What is the purpose of this pull request?
Bug fix
New Feature
Documentation update
Other
Before submitting the PR, please make sure you do the following
If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
mswertz
changed the title
fix: relative paths to __sandbox.html when having base = ""
fix: sandbox URL in getSandboxUrl function when in subdirectory with base = "" (i.e. relative paths)
Feb 19, 2024
mswertz
changed the title
fix: sandbox URL in getSandboxUrl function when in subdirectory with base = "" (i.e. relative paths)
fix: getSandboxUrl function when in subdirectory with base = "" (i.e. relative paths)
Feb 19, 2024
mswertz
changed the title
fix: getSandboxUrl function when in subdirectory with base = "" (i.e. relative paths)
fix: getSandboxUrl function when in subdirectory
Feb 19, 2024
mswertz
changed the title
fix: getSandboxUrl function when in subdirectory
fix: getSandboxUrl function when base="" and published in subdirectory
Feb 24, 2024
mswertz
changed the title
fix: getSandboxUrl function when base="" and published in subdirectory
fix #652: getSandboxUrl function when base="" and published in subdirectory
Feb 24, 2024
mswertz
changed the title
fix #652: getSandboxUrl function when base="" and published in subdirectory
fix: getSandboxUrl function when base="" and published in subdirectory (fix #652)
Feb 24, 2024
mswertz
changed the title
fix: getSandboxUrl function when base="" and published in subdirectory (fix #652)
fix: getSandboxUrl function when base="" and published in subdirectory (fix #652,#635)
Feb 24, 2024
mswertz
changed the title
fix: getSandboxUrl function when base="" and published in subdirectory (fix #652,#635)
fix: getSandboxUrl when base="" and in subdirectory (fix #652,#635)
Feb 24, 2024
mswertz
changed the title
fix: getSandboxUrl when base="" and in subdirectory (fix #652,#635)
fix: getSandboxUrl when base="" served in subdirectory (fix #652,#635)
Feb 24, 2024
the base shouldn't be modified, it should have a slash at the start and at the end (every guide from vite about configuring this have them), adding a slash at the end is wrong
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue when users use histoire using relative paths in a subdirectory.
Workaround is still
<Story :layout="{ type: 'grid', width: '75%' }">
as mentioned in #635Description
This enhances recent PR #652 that made break our histoire setup while using a relative path. We use base = "" however run it in a subfolder so adding the '/' actually breaks it, see image. When I fixed it in my local node_modules folder the code committed solved it.
Additional context
N.B. I am using the nuxt extension. Without this fix I get the following error:
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).