Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add type inference for Story and Variant slots items (fixes #622) #623

Conversation

medfreeman
Copy link
Contributor

@medfreeman medfreeman commented Oct 31, 2023

infer Story & Variant slots state, based on initState

Description

#622

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • If it's a new feature, provide a convincing reason to add it. Ideally, you should open a suggestion issue first and have it approved before working on it.
  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

codesandbox bot commented Oct 31, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Oct 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit 5157f6f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/6541707e310b090008f09d75
😎 Deploy Preview https://deploy-preview-623--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit 5157f6f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/6541707e122709000864c60c
😎 Deploy Preview https://deploy-preview-623--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit 5157f6f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/6541707ec9ca3800080b0e32
😎 Deploy Preview https://deploy-preview-623--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 31, 2023

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit 5157f6f
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/6541707e99c30100085296dc
😎 Deploy Preview https://deploy-preview-623--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@medfreeman medfreeman changed the title types(dev): add type inference for Story and Variant slots items (fixes #622) chore(dev): add type inference for Story and Variant slots items (fixes #622) Oct 31, 2023
@Akryum Akryum changed the title chore(dev): add type inference for Story and Variant slots items (fixes #622) types: add type inference for Story and Variant slots items (fixes #622) Nov 13, 2023
@Akryum Akryum merged commit a430ca4 into histoire-dev:main Nov 13, 2023
@medfreeman medfreeman deleted the types-vue3-story-variant-generic-init-state branch November 13, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants