Added caching to wilson.client.js and wilson.client.min.js endpoints. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,9 +118,19 @@ module.exports = function(app, appWilsonConfigJson, dependencies) { | |||
|
|
|||
| //WILSON CLIENT | |||
| router.get('/:version?/client.wilson.js', function(req, res) { | |||
| //Set max age headers based on config for wilson (NOTE: maxAgeMs is millis, so we divide to specify seconds) | |||
There was a problem hiding this comment.
You might want to check if the req.params.version is set before setting the cache control. Cache should probably be max-age=0 for the case no version is provided.
There was a problem hiding this comment.
Sounds good. I'll open a ticket to add this, but will merge this in for the time being.
There was a problem hiding this comment.
#18 Ticket create for req.params.version addition
hunternovak
added a commit
that referenced
this pull request
May 21, 2015
Added caching to wilson.client.js and wilson.client.min.js endpoints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.