Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): #4101 Fixes parser to parse new lines directly to output #4133

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mohit-nagaraj
Copy link

Fixes parser to parse new lines directly to output.

Closes #4101

Changes

This modification to the addText method ensures that newline characters are properly handled and preserved in the token tree

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

I think the needed fix here is much simpler. The issue (in my testing) was only when we have an illegal match on $ (end of line) that we then insert no content since technically $ matches an empty string not the \n itself... If you'd like to help you could add a markup test with a problematic sample of this - then I'll throw my simper fix and we'll see if things are still green.

@joshgoebel
Copy link
Member

Could you please test #4142

@joshgoebel
Copy link
Member

If you believe you have test cases that my PR doesn't solve, just point me to them and I'll take another look.

@joshgoebel
Copy link
Member

@mohit-nagaraj ping. Could you test my fix against your test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(css) Line breaks disappear
2 participants