remove implicit style #4125
Closed
remove implicit style #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 176 files changedTotal change +280 B View Changes
|
joshgoebel
reviewed
Oct 20, 2024
|
I can't tell what if anything you changed in the README, please revert all the unnecessary linting/spacing changes. The other changes for the base16 styles seem to be correct. I'm thinking they ship "complete" from the Base16 repo they are copied directly from to allow people to use them "as-is" from that repo... where-as the themes here are not meant to be used until they are "cooked" and added to a distribution. So I think this can be merged just as soon as we remove the unnecessary changes to the README. |
You mean in VERSION_11_UPGRADE.md (aebf8d0)? I removed all the unnecessary extra/double spaces.
You want me to add a new revert commit? Or do you prefer to drop this commit while squashing the PR? |
That'd be great. |
Build Size ReportChanges to minified artifacts in 174 files changedTotal change +284 B View Changes
|
|
Actually we may need more work here, but I'm not sure what to suggest. It just clicked that these are actually assets copied directly from another build system. So modifying them in our repo makes no sense - we'd need a script to make this repeatable. Otherwise all this work will be lost when the Base16 themes are rebuilt and copied over whenever we decide to refresh these in the future. I'm thinking it maybe best to leave these "as is" and clean up the small amount of duplication in our own build step. Thoughts? |
|
See last comment. Closing this. I feel like a tiny improvement to clean this up inside our CSS processing pipeline would be a different PR entirely - not a reuse of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove styles that are added automatically by the build system. cf. #4124 (comment)