Added list of false positiitives #3999

akhtarmdsaad · 2024-02-26T13:16:32Z

Issue: (cpp) Keywords followed by parens are treated as built_in

Resolves #3980

Changes

Added list of false positives to FUNCTION_DISPATCH

The List:

      /(?!decltype)/,
      /(?!if)/,
      /(?!for)/,
      /(?!switch)/,
      /(?!while)/,
      /(?!alignas)/,
      /(?!alignof)/,
      /(?!asm)/,
      /(?!catch)/,
      /(?!const_cast)/,
      /(?!dynamic_cast)/,
      /(?!noexcept)/,
      /(?!reinterpret_cast)/,
      /(?!sizeof)/,
      /(?!static_assert)/,
      /(?!static_cast)/,
      /(?!typeid)/,
      /(?!requires)/,
      /(?!explicit)/,
      /(?!case)/,
      /(?!delete)/,
      
      // compound operators
      /(?!bitand_eq)/,
      /(?!bitor_eq)/,
      /(?!xor_eq)/,
      /(?!not_eq)/,
      /(?!or_eq)/,
      /(?!and_eq)/,

      // operators
      /(?!and)/,
      /(?!or)/,
      /(?!bitand)/,
      /(?!bitor)/,
      /(?!xor)/,

      // unary operators
      /(?!not)/,
      /(?!compl)/,
      /(?!co_await)/,
      /(?!co_return)/,
      /(?!co_yield)/,
      
      // Reserved types
      /(?!int)/, 
      /(?!char)/, 
      /(?!double)/, 
      /(?!float)/, 
      /(?!bool)/,
      /(?!auto)/,

Before:

After:

Checklist

Added markup tests, or they don't apply here because...
Updated the changelog at CHANGES.md

github-actions · 2024-02-26T14:02:46Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

5 files changed

Total change +551 B

View Changes

file	base	pr	diff
es/languages/arduino.min.js	4.61 KB	4.74 KB	+137 B
es/languages/cpp.min.js	2.59 KB	2.73 KB	+139 B
highlight.min.js	8.21 KB	8.21 KB	-1 B
languages/arduino.min.js	4.61 KB	4.75 KB	+137 B
languages/cpp.min.js	2.6 KB	2.73 KB	+139 B

akhtarmdsaad · 2024-03-10T01:48:51Z

src/languages/cpp.js

+      /(?!char)/, 
+      /(?!double)/, 
+      /(?!float)/, 
+      /(?!bool)/,


i think this is already working properly. No need to change anything.

What I've mentioned above only happens without ;

Just forget it.

joshgoebel · 2024-07-07T20:50:25Z

Keywords followed by parens are treated as built_in

Could we build the exclude list dynamically from our keywords list then instead of repeating ourselves?

akhtarmdsaad · 2024-07-09T06:03:53Z

Keywords followed by parens are treated as built_in

Could we build the exclude list dynamically from our keywords list then instead of repeating ourselves?

Sure

github-actions · 2024-07-09T06:17:59Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +136 B

View Changes

file	base	pr	diff
es/core.min.js	8.2 KB	8.2 KB	+3 B
es/highlight.min.js	8.2 KB	8.2 KB	+3 B
es/languages/arduino.min.js	4.61 KB	4.63 KB	+28 B
es/languages/cpp.min.js	2.59 KB	2.63 KB	+35 B
highlight.min.js	8.23 KB	8.23 KB	+3 B
languages/arduino.min.js	4.61 KB	4.64 KB	+29 B
languages/cpp.min.js	2.6 KB	2.63 KB	+35 B

github-actions · 2024-07-09T06:20:57Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +133 B

View Changes

file	base	pr	diff
es/core.min.js	8.2 KB	8.2 KB	+2 B
es/highlight.min.js	8.2 KB	8.2 KB	+2 B
es/languages/arduino.min.js	4.61 KB	4.63 KB	+28 B
es/languages/cpp.min.js	2.59 KB	2.63 KB	+35 B
highlight.min.js	8.23 KB	8.23 KB	+2 B
languages/arduino.min.js	4.61 KB	4.64 KB	+29 B
languages/cpp.min.js	2.6 KB	2.63 KB	+35 B

…light.js into fix/issue-3980

github-actions · 2024-07-09T06:23:46Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +135 B

View Changes

file	base	pr	diff
es/core.min.js	8.2 KB	8.2 KB	+3 B
es/highlight.min.js	8.2 KB	8.2 KB	+3 B
es/languages/arduino.min.js	4.61 KB	4.63 KB	+28 B
es/languages/cpp.min.js	2.59 KB	2.63 KB	+35 B
highlight.min.js	8.23 KB	8.23 KB	+2 B
languages/arduino.min.js	4.61 KB	4.64 KB	+29 B
languages/cpp.min.js	2.6 KB	2.63 KB	+35 B

akhtarmdsaad · 2024-07-09T06:32:02Z

Its working fine now.

akhtarmdsaad · 2024-07-12T12:40:30Z

hi @joshgoebel, can you please tell me if our engine has a priority based highlighting or it is just limited to regex. if no such feature exists, should we add this feature to our engine for better control over it?

joshgoebel · 2024-09-22T18:53:03Z

CHANGES.md

@@ -61,6 +61,7 @@ CAVEATS / POTENTIALLY BREAKING CHANGES

 Core Grammars:

+- fix(cpp) Keywords followed by parens are treated as built_in [Md Saad Akhtar][]


Please add your author link below as well.

github-actions · 2024-09-22T18:53:28Z

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

7 files changed

Total change +130 B

View Changes

file	base	pr	diff
es/core.min.js	8.18 KB	8.18 KB	+1 B
es/highlight.min.js	8.18 KB	8.18 KB	+1 B
es/languages/arduino.min.js	4.61 KB	4.63 KB	+28 B
es/languages/cpp.min.js	2.59 KB	2.63 KB	+35 B
highlight.min.js	8.22 KB	8.22 KB	+1 B
languages/arduino.min.js	4.61 KB	4.64 KB	+29 B
languages/cpp.min.js	2.6 KB	2.63 KB	+35 B

joshgoebel

All we need is that link then we can get this merged! Thanks for your patience.

joshgoebel · 2024-10-31T21:32:11Z

src/languages/cpp.js

-      /(?!switch)/,
-      /(?!while)/,
+      // adds all keywords dynamically
+      ...allKeywords.map(keyword => new RegExp(`(?!${keyword})`)),


Actually don't we only care about keywords here that can potentially have a ( following them? That's not ALL keywords, is it?

We can ignore this for now since I already said this was ready but need your author link...

akhtarmdsaad added 3 commits February 26, 2024 12:04

Added list of false positiitives

913d32d

Added markup tests

89853e2

Merge branch 'main' into fix/issue-3980

81079eb

tomwt-awa approved these changes Mar 9, 2024

View reviewed changes

tomwt-awa suggested changes Mar 9, 2024

View reviewed changes

akhtarmdsaad added 2 commits July 9, 2024 11:38

keywords update dynamically

2b3fa7b

fixed keywords with parentheses problem

68619d1

akhtarmdsaad and others added 2 commits July 9, 2024 11:49

updated changes.md

0b50faf

Merge branch 'highlightjs:main' into fix/issue-3980

d14ec57

Merge branch 'fix/issue-3980' of https://github.com/akhtarmdsaad/high…

6e14ee8

…light.js into fix/issue-3980

TOMWT-qwq approved these changes Jul 15, 2024

View reviewed changes

Merge branch 'main' into fix/issue-3980

c7eeeca

joshgoebel reviewed Sep 22, 2024

View reviewed changes

joshgoebel requested changes Sep 22, 2024

View reviewed changes

joshgoebel reviewed Oct 31, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added list of false positiitives #3999

Added list of false positiitives #3999

akhtarmdsaad commented Feb 26, 2024

github-actions bot commented Feb 26, 2024

This comment was marked as outdated.

This comment was marked as outdated.

akhtarmdsaad Mar 10, 2024 •

edited

Loading

TOMWT-qwq Jul 15, 2024

joshgoebel commented Jul 7, 2024

akhtarmdsaad commented Jul 9, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 9, 2024

akhtarmdsaad commented Jul 9, 2024

akhtarmdsaad commented Jul 12, 2024

joshgoebel Sep 22, 2024

joshgoebel Oct 31, 2024

github-actions bot commented Sep 22, 2024

joshgoebel left a comment

joshgoebel Oct 31, 2024

joshgoebel Oct 31, 2024

		@@ -61,6 +61,7 @@ CAVEATS / POTENTIALLY BREAKING CHANGES

		Core Grammars:

		- fix(cpp) Keywords followed by parens are treated as built_in [Md Saad Akhtar][]

Added list of false positiitives #3999

Are you sure you want to change the base?

Added list of false positiitives #3999

Conversation

akhtarmdsaad commented Feb 26, 2024

Changes

Before:

After:

Checklist

github-actions bot commented Feb 26, 2024

Build Size Report

5 files changed

This comment was marked as outdated.

This comment was marked as outdated.

akhtarmdsaad Mar 10, 2024 • edited Loading

Choose a reason for hiding this comment

TOMWT-qwq Jul 15, 2024

Choose a reason for hiding this comment

joshgoebel commented Jul 7, 2024

akhtarmdsaad commented Jul 9, 2024

github-actions bot commented Jul 9, 2024

Build Size Report

7 files changed

github-actions bot commented Jul 9, 2024

Build Size Report

7 files changed

github-actions bot commented Jul 9, 2024

Build Size Report

7 files changed

akhtarmdsaad commented Jul 9, 2024

akhtarmdsaad commented Jul 12, 2024

joshgoebel Sep 22, 2024

Choose a reason for hiding this comment

joshgoebel Oct 31, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 22, 2024

Build Size Report

7 files changed

joshgoebel left a comment

Choose a reason for hiding this comment

joshgoebel Oct 31, 2024

Choose a reason for hiding this comment

joshgoebel Oct 31, 2024

Choose a reason for hiding this comment

akhtarmdsaad Mar 10, 2024 •

edited

Loading